Skip to content

[WASMFS] Comprehensive dup test #15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2021
Merged

[WASMFS] Comprehensive dup test #15550

merged 3 commits into from
Nov 17, 2021

Conversation

ethanalee
Copy link
Collaborator

Relevant Issue: #15041

Verifies that this issue has been fixed with the dup syscall: #4017

dup()ed file descriptors should share all flags (and also seek position). Opening same file twice is not the same thing

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it would be great if we could fix #4017 for the old filesystem too. Just because we on the way out doesn't mean we should not try to fix bugs in it (within reason). But thats not related to this issue.

@ethanalee ethanalee linked an issue Nov 17, 2021 that may be closed by this pull request
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo that comment

@ethanalee ethanalee merged commit 1e2e30f into main Nov 17, 2021
@ethanalee ethanalee deleted the wasmfs-dup-test branch November 17, 2021 21:44
mmarczell-graphisoft pushed a commit to GRAPHISOFT/emscripten that referenced this pull request Jan 5, 2022
Relevant Issue: emscripten-core#15041

Verifies that this issue has been fixed with the dup syscall: emscripten-core#4017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dup() syscall is wrongly implemented
4 participants